[PATCH] D70418: AMDGPU: Handle waitcnt overflow

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 10:50:29 PST 2019


kerbowa added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-overflow.mir:8
+---
+name:            max-counter-lgkmcnt
+body:             |
----------------
arsenm wrote:
> kerbowa wrote:
> > arsenm wrote:
> > > Should also add an exp test
> > Do you have an suggestion on adding an exp test?
> just use a lot of EXPs?
Okay. But fox expcnt we already reset the LB when we have an overflow, and just don't insert any wait. This change should never affect expcnt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70418/new/

https://reviews.llvm.org/D70418





More information about the llvm-commits mailing list