[PATCH] D70404: [ThinLTO] Always import constants
Steven Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 21 10:14:17 PST 2019
steven_wu added a comment.
In D70404#1755124 <https://reviews.llvm.org/D70404#1755124>, @evgeny777 wrote:
> I reimplemented the patch, now using extra 'Constant' attribute in GlobalVarSummary.
>
> The goal is to allow importing of constants, which are not being detected as 'ReadOnly'. Such constants are imported with available_externally linkage, still allowing compiler to make some optimizations along the way.
Looks good at first glimpse. Out of curiosity, what problem do you run into when you unify `ReadOnly` with `Constant`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70404/new/
https://reviews.llvm.org/D70404
More information about the llvm-commits
mailing list