[PATCH] D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: compiler-rt/test/profile/Windows/Inputs/instrprof-multiwrite.c:57
+int foo(int num) {
+  if (num < 5) {
+    return 1;
----------------
hans wrote:
> I know dxf suggested adding some control-flow here, but I don't see why. Isn't just the function entry counts enough to verify that we've merged the profile info successfully? I'd suggest keeping it simple.
Since it is a merging test, it is better IMO to  sanity test internal counts are merged properly as well with the simple control flow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70330/new/

https://reviews.llvm.org/D70330