[PATCH] D70452: [scudo][standalone] Minor optimization & improvements

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 09:10:45 PST 2019


cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:167
     initThreadMaybe();
-    ZeroContents = ZeroContents || Options.ZeroContents;
+    ZeroContents |= !!Options.ZeroContents;
 
----------------
hctim wrote:
> `!!`?
`Options.ZeroContents` is technically not a boolean, and I really want to have a boolean when using a bitwise or (since the logical or adds a long condition jump).
Hence the double logical not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70452/new/

https://reviews.llvm.org/D70452





More information about the llvm-commits mailing list