[PATCH] D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope marked 6 inline comments as done.
bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchFolding.cpp:363-364
         // directives.
-        I1->isInlineAsm()) {
-      ++I1; ++I2;
+        // FIXME: If inline asm check really is needed, then why don't we also
+        // check MBBI2?
+        MBBI1->isInlineAsm()) {
----------------
jmorse wrote:
> Presumably if we pass isIdenticalTo, MBBI2 must presumably point at a duplicate INLINE_ASM instruction?
Thanks, I misread this first (as if the isInlineAsm check was done if isIdenticalTo was false, but the code actually only check isInlineAsm when isIdenticalTo is true, so I've removed my extra FIXME again).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70091/new/

https://reviews.llvm.org/D70091