[PATCH] D70522: [llvm-lipo] Implement -extract
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 21 08:43:24 PST 2019
compnerd accepted this revision.
compnerd added inline comments.
================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:408
+ if (C.OutputFile.empty())
+ reportError("extract expects a single output file");
+ C.ActionToPerform = LipoAction::ExtractArch;
----------------
Why not hoist this above the architecture check? This should be super cheap, and avoids doing I/O unless the inputs are good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70522/new/
https://reviews.llvm.org/D70522
More information about the llvm-commits
mailing list