[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 08:52:59 PST 2019
dstenb added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:272-273
if (MO.isReg() && MO.isDef() && MO.getReg()) {
// Ignore call instructions that claim to clobber SP. The AArch64
// backend does this for aggregate function arguments.
+ if (MI.isKill() || MI.isCall() && MO.getReg() == SP)
----------------
At a quick glance one could think that the `isKill()` condition is related to the above, so I think that the comment needs to be updated (or the `isKill()` condition moved to its own if statement).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70497/new/
https://reviews.llvm.org/D70497
More information about the llvm-commits
mailing list