[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 08:16:25 PST 2019


TWeaver created this revision.
TWeaver added reviewers: aprantl, dblaikie, probinson, vsk.
TWeaver added a project: debug-info.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Noop Kill instructions would be classified as a clobber of the register they kill by the debug entity calculator. This would in turn close the range of a preceding debug intrinsic that could potentially have it's range extended past the KILL instructions invocation.

This patch address this issue by making the Debug History Entity Calculator ignore Kill instructions when calculating location list ranges. Two tests failed as result, these have now been fixed up and a new test has been added that specifically tests for this exact case.

Happy reviewing,
Tom W


https://reviews.llvm.org/D70497

Files:
  llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
  llvm/test/DebugInfo/COFF/pieces.ll
  llvm/test/DebugInfo/X86/kill_instruction_doesnt_close_dbg_intrinsic_range.mir
  llvm/test/DebugInfo/X86/pieces-3.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70497.230269.patch
Type: text/x-patch
Size: 6928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191120/22970a53/attachment-0001.bin>


More information about the llvm-commits mailing list