[PATCH] D70009: [ARM][ReachingDefs] RDA in LoLoops

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

I think this all looks OK. Unless Sjoerd/others have further comments. I don't feel like an expert on RDA..

In any case, perhaps leave open for a few days for anyone else to make comments.



================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:113
+
+  // Provides the clearance - the number of instructions since the closest
   /// reaching def instuction of PhysReg that reaches MI.
----------------
Lost a / out of ///


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:233
+  LiveRegs.addLiveOuts(*MBB);
+  if (LiveRegs.contains(PhysReg))
+    return true;
----------------
Hmm. You don't know if this is the _same_ PhysReg, right? It could be a different def of the same register?

That would still fit in with how RDA works, but is kind of mixing together liveness and reachability.

Yeah OK. I think this expands reaching defs in a sensible direction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70009/new/

https://reviews.llvm.org/D70009