[PATCH] D70240: [ARM][ReachingDefs] Remove dead code in loloops.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 05:12:23 PST 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/mve-tail-data-types.ll:14
 ; CHECK-NEXT:    movs r3, #0
-; CHECK-NEXT:    dlstp.32 lr, lr
+; CHECK-NEXT:    dlstp.32 lr, r12
 ; CHECK-NEXT:  .LBB0_1: @ %vector.body
----------------
SjoerdMeijer wrote:
> This doesn't seem correct to me as we haven't set up `r12`, the iteration count lives in `r2`.
Good one spotting this, the logic is obviously wrong and not handling the mov r12, r2 in the loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70240/new/

https://reviews.llvm.org/D70240





More information about the llvm-commits mailing list