[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

Thu Nov 21 03:01:08 PST 2019

teemperor added a comment.

FYI, this doesn't compile, see: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/10890 (and probably all other build bots that are starting to break).

  FAILED: tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o                                                                                                                                                             
  /usr/lib/ccache/bin/clang++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/sancov -I/home/teemperor/work/ci/llvm/llvm/tools/sancov -I/usr/
  include/libxml2 -Iinclude -I/home/teemperor/work/ci/llvm/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wc
  ast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-col
  or -ffunction-sections -fdata-sections -O3    -UNDEBUG  -fno-exceptions -fno-rtti -std=c++14 -MD -MT tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o -MF tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o.d -o tools/
  sancov/CMakeFiles/sancov.dir/sancov.cpp.o -c /home/teemperor/work/ci/llvm/llvm/tools/sancov/sancov.cpp                                                                                                              
  /home/teemperor/work/ci/llvm/llvm/tools/sancov/sancov.cpp:513:56: error: too few arguments to function call, expected 2, have 1                                                                                     
      return SpecialCaseList::createOrDie({{ClBlacklist}});                                                                                                                                                           
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~                ^                                                                                                                                                            
  /home/teemperor/work/ci/llvm/llvm/include/llvm/Support/SpecialCaseList.h:80:3: note: 'createOrDie' declared here                                                                                                    
    static std::unique_ptr<SpecialCaseList>                                                                                                                                                                           
    ^                                                                                                                                                                                                                 
  1 error generated. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70440/new/

https://reviews.llvm.org/D70440