[PATCH] D70505: [ELF] Replace SymbolTable::forEachSymbol with filter_iterator begin()/end()

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 01:39:09 PST 2019


peter.smith added a comment.

I'm comfortable with defining a filter iterator, I think the trade off of increased complexity vs simple interface is worth it. I can see some benefit in ```for (Symbol *sym : symtab->symbols())``` as it is not clear from sym : symtab that PlaceHolders are being skipped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70505/new/

https://reviews.llvm.org/D70505





More information about the llvm-commits mailing list