[PATCH] D70487: Summary:[DAGCombiner] Allow zextended load combines.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

couple of minors



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6784
+      // zero-extend the load.
+      if (++ZeroExtendedBytes != ByteWidth - static_cast<unsigned>(i))
+        return SDValue();
----------------
Extra brackets to avoid static analyzer precedence warnings
```
(++ZeroExtendedBytes != (ByteWidth - static_cast<unsigned>(i)))
```


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6789
+
+    assert(P->isMemory() && "unimplemented");
+
----------------
Improve the assertion message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70487/new/

https://reviews.llvm.org/D70487