[PATCH] D70460: export.sh: Fetch sources from GitHub instead of SVN

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 00:36:13 PST 2019


hans added inline comments.


================
Comment at: llvm/utils/release/export.sh:53
+
+    for proj in $projects; do
+        echo "Creating tarball for $proj ..."
----------------
sylvestre.ledru wrote:
> tstellar wrote:
> > hans wrote:
> > > When I was thinking about this, I figured maybe we should just ship llvm-project.tar.xz and test-suite.tar.xz, rather than split up into the old project structure?
> > > 
> > > It seems odd in a way to release in a format that doesn't match the code layout used by developers. Do you think the llvm-projects.tar.xz tarball would be prohibitively large? Or that the change is too large for users of the release?
> > If we distributed a single tarball, that would be easy, because GitHub creates one for us and adds it to the list of release assets.  The gz compressed file generated by GitHub is 108M. 
> > 
> > However, as a distro packager, I prefer having the separate tarballs because that's what we use for building packages on Fedora and RHEL.
> > 
> > @mgorny, @sylvestre.ledru  Do you have any thoughts about this?
> For Debian & Ubuntu, I moved to a single tarball containing it all. Splitting tarballs doesn't bring much values compare to the maintenance cost.
> 
> BTW, using xz, the tarball is only 72M for 9.0.0
> 
I see.

I don't have strong opinions about this, but I always assumed that the non-monorepo layout build would go away at some point after the migration.

Maybe we should release both an llvm-project.tgz "monorepo tarball" and the separate ones for a while?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70460/new/

https://reviews.llvm.org/D70460





More information about the llvm-commits mailing list