[PATCH] D70492: LLD: Assign the stderrOS and stdoutOS globals to the new argument values, before using via enableColors.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 20:23:15 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/MinGW/Driver.cpp:167
 
+  enableColors(stderrOS.has_colors());
+
----------------
`enableColors` is a singe-line function and doesn't seem to provide much value. Can you replace this with `stderrOS.enable_colors(stderrOS.has_colors())` and remove `enableColors` function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70492/new/

https://reviews.llvm.org/D70492





More information about the llvm-commits mailing list