[PATCH] D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov accepted this revision.
skatkov added a comment.
This revision is now accepted and ready to land.

In D70104#1753816 <https://reviews.llvm.org/D70104#1753816>, @twoh wrote:

> Addressing comments from @skatkov. Thank you for your review!
>
> For X86 asm tests, I just re-ran update_llc_test_checks.py script. I think it should generate "correct" test based on the existing FileCheck patterns?


It will generate checks corresponding to the current implementation, what I worry about is that it still checks that "spill is hoisted to a cold BB inside the hotter outer loop."
To ensure it that we need to understand what it did before and does now what is untrivial :)
I see many updates of this test and not sure that all of them checked that the original target of the test still make sense :)

Let add an author introduced it in 2014. If he does not react to this patch in 1-2 days. Feel free to land.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70104/new/

https://reviews.llvm.org/D70104