[PATCH] D70515: [WebAssembly] Create a __stack_limit variable

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 16:34:31 PST 2019


sunfish added a comment.

In D70515#1754288 <https://reviews.llvm.org/D70515#1754288>, @sbc100 wrote:

> Does this need to be wasm global?   Or can it just be regular data symbol like `globalBase`?   i.e. do we want fast access to it without a load?


I made it a global because I was thinking about multiple threads, where each thread has its own stack. But that's true, we could do a data symbol in the single-threaded case. I'll look into that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70515/new/

https://reviews.llvm.org/D70515





More information about the llvm-commits mailing list