[PATCH] D70507: Fix PR44093: use of stale error stream when linking
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 15:58:14 PST 2019
ruiu added inline comments.
================
Comment at: lld/COFF/Driver.cpp:75
lld::stderrOS = &stderrOS;
+ enableColors(stderrOS.has_colors());
----------------
Let's remove `enableColors` and replace it with `stderrOS..enable_colors(stderrOS.has_colors())`. I wrote that single-line function but in hindsight it doesn't provide much value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70507/new/
https://reviews.llvm.org/D70507
More information about the llvm-commits
mailing list