[PATCH] D69847: DWARFDebugLoc(v4): Add an incremental parsing function

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D69847#1753935 <https://reviews.llvm.org/D69847#1753935>, @labath wrote:

> In D69847#1753814 <https://reviews.llvm.org/D69847#1753814>, @dblaikie wrote:
>
> > Hmm, I'm not seeing these extra ulebs in GCC's output in this example: https://godbolt.org/z/x5RvMY - am I missing something in the reproduction or not reading it accurately?
>
>
> It looks like you need to add ` -gvariable-location-views` to the command line. I'm not sure what's the difference, but my build of gcc seems to have it on by default, and godbolt's doesn't.


Ah, that is a curious switch indeed. And, yeah, the existence of that feature sounds like a very solid justification that we should consider moving in the direction of not trying to parse arbitrary parts of non-debug_info sections (only those referenced from debug_info itself) except /maybe/ in a very exploratory debugging mode, and/or phrased differently in terms of "attempted to parse hole in debug_loc [offset1:offset2), but failed: <reason>"

> I'm going to reply to the other comment tomorrow.

Ah, sure - that was a comment I didn't realize I'd written a while back and had failed to hit "send" on, feel free to ignore it if it doesn't make any more sense today or the like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69847/new/

https://reviews.llvm.org/D69847