[PATCH] D70513: [VectorUtils] API for VFShape.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 14:43:40 PST 2019


fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: llvm/unittests/Analysis/VectorUtilsTest.cpp:315
+  buildShape(/*VF*/ 2, /*IsScalable*/ false, /*HasGlobalPred*/ false);
+  Expected = {/*VF*/ 2, /*IsScalable*/ false, /*HasGlobalPred*/ {
+                  {0, VFParamKind::Vector},
----------------
This should be `/*Parameters*/`, not `/*HasGlobalPredicate*/`. Same for all uses below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70513/new/

https://reviews.llvm.org/D70513





More information about the llvm-commits mailing list