[PATCH] D70508: Fix an offset underflow bug in DwarfExpression when describing small values with subregisters
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 14:06:00 PST 2019
aprantl marked an inline comment as done.
aprantl added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:168
+ // Mark it as emitted.
+ Coverage.set(Offset, Offset + Size);
+ CurPos = Offset + Size;
----------------
vsk wrote:
> Is it a requirement that all bits in `MachineReg` be described? What happens is there's an unset bit in `Coverage`?
All "holes" are covered by empty "no DWARF register encoding" empty pieces (see line 164 and 176).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70508/new/
https://reviews.llvm.org/D70508
More information about the llvm-commits
mailing list