[PATCH] D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate

Michael Holman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 12:33:05 PST 2019


Holman marked an inline comment as done.
Holman added inline comments.


================
Comment at: compiler-rt/test/profile/Windows/instrprof-multiwrite.test:6
+RUN: %run %t
+RUN: llvm-profdata show -function=foo %t_*.profraw | FileCheck %s
+
----------------
davidxl wrote:
> add option --counts to check the exact profile counts.
I can add --counts if you want, but the only thing that added is:
    Block counts: []
For me, the "Function count: 10" was really the most important output to validate that all calls were recorded.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70330/new/

https://reviews.llvm.org/D70330





More information about the llvm-commits mailing list