[PATCH] D68779: [LNT][NFC] Fix global import in function

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D68779#1743986 <https://reviews.llvm.org/D68779#1743986>, @thopre wrote:

> In D68779#1741898 <https://reviews.llvm.org/D68779#1741898>, @thopre wrote:
>
> > In D68779#1741077 <https://reviews.llvm.org/D68779#1741077>, @thopre wrote:
> >
> > > In D68779#1741055 <https://reviews.llvm.org/D68779#1741055>, @cmatthews wrote:
> > >
> > > > I don't understand why we are not using normal import at the top level here?
> > >
> > >
> > > According to a comment in the file it's done this way to load dependencies lazily. It does not say why it is desirable to do so though. Since the same dependencies are loaded for all admin subcommand I'd say it's probably not necessary but I'd prefer to fix that in a separate patch once all Python 3 support patches are in to keep this one a NFC.
> >
> >
> > @MatzeB Can you confirm what is the purpose of loading lnt admin dependencies lazily?
>
>
> Matthias replied saying the point was to avoid adding some extra package requirement for the client side of LNT. So I think the patch stands as it is.


@hubert.reinterpretcast @cmatthews Ping?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68779/new/

https://reviews.llvm.org/D68779