[PATCH] D69989: Assume ieee behavior without denormal-fp-math attribute

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 11:19:32 PST 2019


spatel added a comment.

In D69989#1753683 <https://reviews.llvm.org/D69989#1753683>, @cameron.mcinally wrote:

> Attn: @craig.topper @eli.friedman. The FMF behavior looks like it will take a performance hit with the switch to default IEEE conformance. Is this something that needs to be publicized on llvm-dev before merging? Users who don't care will want to add an explicit `denormal-fp-math` attribute to their code.


I think this patch is dependent on D69979 <https://reviews.llvm.org/D69979> (set the denorm attributes based on other clang behavior). We need a test-suite end-to-end test or at least have clang tests reference the expected codegen tests, so we know that handshake between front-end and codegen is working as expected.

> Nit: the IR tests may be overly brittle -- checking for specific registers. It might be good to use `update_test_checks.py` so that we get the regex'd register expressions.

Agree - if possible, regenerate/add tests as NFC changes before this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69989/new/

https://reviews.llvm.org/D69989





More information about the llvm-commits mailing list