[PATCH] D69332: Implement the Waymarking as an independent utility

Wed Nov 20 11:16:26 PST 2019

foad added a comment.

In D69332#1753682 <https://reviews.llvm.org/D69332#1753682>, @ekatz wrote:

> How do you and @craig.topper suggest I should separate it into 2 patches?
>  As I've explained, I can't separate the improvement of the algorithm from the one in the patch. I would have to re-design, re-write, re-test everything.

Yes I am suggesting (not insisting) that you re-write and re-test the patch. Sorry if that seems like a lot of work, but I don't think it's unreasonable. As the contributing guide says: Independent changes should be submitted as separate patches as this makes reviewing easier.

> The solution I propose is the one I am using on my personal project. I work with it for more than a year, now. Just thought to share it (plus - I added tests and updated the docs as needed).

I appreciate that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69332/new/

https://reviews.llvm.org/D69332