[PATCH] D70473: [AMDGPU] Keep consistent check of legal addressing mode.

[Michael Liao via Phabricator via llvm-commits]

hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:1434
+  auto Base = TII->getNamedOperand(MI, AMDGPU::OpName::vaddr);
+  Base->setReg(NewBase);
+  Base->setIsKill(false);
----------------
arsenm wrote:
> This is a separate change
yeah, but this trivial issue is exposed with the new tests added. I'd like to address here as that's the general thing when a register operand is replaced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70473/new/

https://reviews.llvm.org/D70473