[PATCH] D70472: scudo: Only use the Android reserved TLS slot when building libc's copy of the allocator.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 10:39:57 PST 2019


pcc added a comment.

In D70472#1753626 <https://reviews.llvm.org/D70472#1753626>, @cryptoad wrote:

> Does this incur a minimal toolchain revision or something since I think ELF TLS was only added recently?


Yes, it requires NDK r21, which was the first revision to include https://android-review.googlesource.com/c/platform/bionic/+/967181 which made Android's ELF TLS compatible with current lld.

I'm not sure if we document the minimum NDK revision anywhere though, and different components have different requirements. It's probably fine to require r21 for scudo since not many folks aside from platform developers will be using/testing it on Android.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70472/new/

https://reviews.llvm.org/D70472





More information about the llvm-commits mailing list