[PATCH] D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson marked an inline comment as done.
chrisjackson added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2755
 
+std::tuple<size_t, size_t> CropHeaderBytes(PhdrEntry *programHeader,
+                                           PhdrEntry *programHeaderTable,
----------------
ruiu wrote:
> Do you think you can move the new code to watermark.{cpp,h} and add file comment to explain (1) what this is and (2) how watermark is computed?
I have begun work on a revision with the watermarking code in a separate library so that it can be shared with the utility that checks the watermark.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66426/new/

https://reviews.llvm.org/D66426