[PATCH] D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 08:07:21 PST 2019


jasonliu marked 2 inline comments as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:313
     const MCSectionXCOFF *ContainingCsect = XSym->getContainingCsect();
-    assert(WrapperMap.find(ContainingCsect) != WrapperMap.end() &&
-           "Expected containing csect to exist in map");
-
+    assert(ContainingCsect && "Every MCSymbolXCOFF should have a csect.");
+   
----------------
daltenty wrote:
> getContainingCsect() already has this assertion internally
You are right. Removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70443/new/

https://reviews.llvm.org/D70443





More information about the llvm-commits mailing list