[PATCH] D70495: [llvm-readobj/llvm-readelf] - Reimplement dumping of the SHT_GNU_verdef section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 07:57:42 PST 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht.
Herald added subscribers: seiya, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

Currently we have following issues:

1. We have 2 different implementations with a different behaviors for GNU/LLVM styles.
2. Errors are either not handled at all or we call report_fatal_error with not helpfull messages.
3. There is no test coverage even for those errors that are reported.

This patch reimplements parsing of the SHT_GNU_verdef section entries
in a single place, adds a few error messages and test coverage.


https://reviews.llvm.org/D70495

Files:
  llvm/test/tools/llvm-readobj/elf-versioninfo.test
  llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70495.230266.patch
Type: text/x-patch
Size: 16346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191120/bf1a6881/attachment-0001.bin>


More information about the llvm-commits mailing list