[PATCH] D67281: [AArch64][SimplifyCFG] Add additional cost for instructions in mergeConditionalStoreToAddress

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2428
+    for (const auto& Instr : *DomBlock)
+    {
+      if (!isa<BranchInst>(&Instr))
----------------
Not clang-formatted


================
Comment at: llvm/test/Transforms/SimplifyCFG/AArch64/check-instr-cost-for-folding.ll:25-29
+if.then:                                          ; preds = %for.body.lr.ph
+  %or = or i64 0, %bit
+  %inc = add nsw i32 0, 1
+  br label %if.end
+
----------------
I think this testcase is overreduced, which makes it impossible to actually guess what the fix should be.
https://godbolt.org/z/sxmNMd


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67281/new/

https://reviews.llvm.org/D67281