[PATCH] D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 05:00:49 PST 2019


hans added a comment.

Hmm, the test looks more like a unit test for lprofOpenFileEx() rather than something that tests profile merging.

The other tests in profile/ are more like integration tests. Would it be possible to write one for this case also? For example, could we have a test program that spawns N subprocesses, which each call some function, and then we check that the profile data reflects that the function's entry count is N?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70330/new/

https://reviews.llvm.org/D70330





More information about the llvm-commits mailing list