[PATCH] D70431: [DebugInfo] Make describeLoadedValue() reg aware

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

> Does this reduce/remove the need for this piece of logic in AArch64's ISel lowering?
> 
>   //Call site info is used for function's parameter entry value
>   //tracking. For now we track only simple cases when parameter
>   // is transferred through whole register.
>    CSInfo.erase(std::remove_if(CSInfo.begin(), CSInfo.end(),
>           [&VA](MachineFunction::ArgRegPair ArgReg) {
>       return ArgReg.Reg == VA.getLocReg();
>   }),
>   CSInfo.end());

I think so.



================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:7566
+    return DIExpression::get(MF->getFunction().getContext(), Ops);
+  };
+
----------------
vsk wrote:
> Can this just be a helper method in DIExpression? It's possible that replaceAllDbgUsesWith could use this.
+1

There are cases (e.g. `salvageDebugInfo()`) where this can be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70431/new/

https://reviews.llvm.org/D70431