[PATCH] D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 06:57:44 PST 2019


davezarzycki added a comment.

In D70079#1753468 <https://reviews.llvm.org/D70079#1753468>, @lebedev.ri wrote:

> In D70079#1753459 <https://reviews.llvm.org/D70079#1753459>, @davezarzycki wrote:
>
> > 257acbf6aee983227a3976d10d0086f3600f2bee <https://reviews.llvm.org/rG257acbf6aee983227a3976d10d0086f3600f2bee>
>
>
> There was this line:
>
> In D70079#1753422 <https://reviews.llvm.org/D70079#1753422>, @lebedev.ri wrote:
>
> > But please wait a bit for @deadalnix / @craig.topper / @RKSimon.
>


Oh, sorry, I missed that there was a comment above the quoted text in addition to below it. I'm happy to revert this if somebody wants, or fix things in a followup patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70079/new/

https://reviews.llvm.org/D70079





More information about the llvm-commits mailing list