[PATCH] D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY
David Zarzycki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 06:34:59 PST 2019
davezarzycki marked 3 inline comments as done.
davezarzycki added inline comments.
================
Comment at: test/CodeGen/X86/addcarry.ll:623
+; Either the primary addition can overflow or the addition of the carry, but
+; they cannot both overflow.
----------------
lebedev.ri wrote:
> Please precommit all tests first.
Oh, whoops. I missed this feedback once I saw the "ready to land" status change. Sorry. At least all of the other tests were pre-committed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70079/new/
https://reviews.llvm.org/D70079
More information about the llvm-commits
mailing list