[PATCH] D70318: Recover debug intrinsics when killing duplicate or empty basic blocks

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 01:43:24 PST 2019


StephenTozer marked an inline comment as done.
StephenTozer added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:3258
+/// or a fragment thereof.
+class DebugVariable {
+  using FragmentInfo = DIExpression::FragmentInfo;
----------------
aprantl wrote:
> aprantl wrote:
> > Can you break this out into a separate NFC commit with a unit test?
> @Orlando cf. the discussion in https://reviews.llvm.org/D70121
What sort of test coverage would be appropriate for a class like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70318/new/

https://reviews.llvm.org/D70318





More information about the llvm-commits mailing list