[PATCH] D54439: CMake: Make most target symbols hidden by default

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In D54439#1744353 <https://reviews.llvm.org/D54439#1744353>, @rnk wrote:

> In D54439#1744319 <https://reviews.llvm.org/D54439#1744319>, @tstellar wrote:
>
> > I've confirmed that this change does fix the warning.  How do we we want to proceed with this patch?  The warnings will still be present on existing Mac OS installs.  Should we disable this change on Mac OS for now or should we keep it and live with the warnings?
>
>
> I'd be in favor of letting Mac use default visibility for now. One way to make this more palatable would be to have a CMake option that allows users to override the default and get hidden visibility if they really want it.


I'm also in favor of keeping default visibility on Mac.  We're trying to cut down on the number of CMake options, so I would prefer not to add an option for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54439/new/

https://reviews.llvm.org/D54439