[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file

[dmajor via Phabricator via llvm-commits]

dmajor added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:377
+#if defined(__Fuchsia__) || defined(_WIN32)
+  PROF_ERR("%s\n", "Continuous mode not yet supported on Fuchsia or Windows.");
+#else // defined(__Fuchsia__) || defined(_WIN32)
----------------
@vsk Doesn't this unconditionally break profiling on Fuschia/Windows? Should there at least be a check for `__llvm_profile_is_continuous_mode_enabled()` before erroring out? I'm currently testing my project's Windows build with trunk, and it's failing here even though we didn't enable continuous mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68351/new/

https://reviews.llvm.org/D68351