[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

[Lewis Revill via Phabricator via llvm-commits]

lewis-revill added a comment.

See comments above. Otherwise, this looks good to me although others should evaluate too.



================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:72
 
   if (Val != nullptr) {
+    // TODO: Only integer, pointer and aggregate types are supported now.
----------------
I don't know whether other people prefer this as well, but I'd prefer the condition here to be reversed and simply duplicate the 

```
MIRBuilder.insertInstr(Ret);
return true;
```

IE:

```
if (Val == nullptr) {
  MIRBuilder.insertInstr(Ret);
  return true;
}

// ...

MIRBuilder.insertInstr(Ret);
return true;
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808