[PATCH] D70318: Recover debug intrinsics when killing duplicate or empty basic blocks

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:3257
+/// Storage for identifying a potentially inlined instance of a variable,
+/// or a fragment thereof.
+class DebugVariable {
----------------
That comment is a bit vague for DebugInfoMetadata.

Does this represent exactly one non-overlapping fragment of an inlined instance of a variable? We should say so. Since this isn't used anywhere in this file, there should be an example for when to use this.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:3258
+/// or a fragment thereof.
+class DebugVariable {
+  using FragmentInfo = DIExpression::FragmentInfo;
----------------
Can you break this out into a separate NFC commit with a unit test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70318/new/

https://reviews.llvm.org/D70318