[PATCH] D70038: [AMDGPU] add support for hostcall buffer pointer as hidden kernel argument

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 02:41:04 PST 2019


sameerds marked 2 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/opencl-printf-no-hostcall.ll:16
+
+declare <2 x i64> @__ockl_hostcall_internal(i8* %0, i32 %1, i64 %2, i64 %3, i64 %4, i64 %5, i64 %6, i64 %7, i64 %8, i64 %9)
+
----------------
arsenm wrote:
> Drop the argument names here which I'm surprised even parse?
Fixed this in the commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70038/new/

https://reviews.llvm.org/D70038





More information about the llvm-commits mailing list