[PATCH] D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 02:18:03 PST 2019


davezarzycki updated this revision to Diff 230217.
davezarzycki added a comment.

Update the patch now that the DAG RAUW versus Combiner discussion has settled down. I personally like the former because it's simpler, but I do like the arguments in favor of the DAGCombiner. Either way, I'll defer to a code owner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70079/new/

https://reviews.llvm.org/D70079

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/addcarry.ll
  test/CodeGen/X86/subcarry.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70079.230217.patch
Type: text/x-patch
Size: 24577 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191120/69fc7978/attachment.bin>


More information about the llvm-commits mailing list