[PATCH] D69434: ExecutionEngine: add preliminary support for COFF ARM64

Wed Nov 20 01:43:23 PST 2019

mstorsjo added inline comments.

================
Comment at: test/ExecutionEngine/RuntimeDyld/AArch64/COFF_AArch64.s:127
+# IMAGE_REL_ARM64_SECREL
+# rtdyld-check: *{4}secrel = string - section_addr(COFF_AArch64.obj, .data)
+secrel:
----------------
kaadam wrote:
> kaadam wrote:
> > mstorsjo wrote:
> > > FWIW, I had to fix up the filename here, to `COFF_AArch64.s.tmp.obj` to make the tests pass. Pushed with that changed.
> > That's interesting. I ran tests manually, so I think that's why I didn't noticed this failure.  So LLVM test infrastructure use this form of the object file? Thanks for fixing that. 
> > There was no problem with check in line 39?
> >  # rtdyld-check:  decode_operand(brel, 0)[25:0] = (stub_addr(COFF_AArch64.obj/.text, dummy) - brel)[27:2]
> Ahh sorry, I see now, you've modified that as well. Thanks again. 
That's how the test infrastructure expands it yes. The %t expands to a temporary file name based on the current file name, plus .tmp.

You can manually run the tests for just one file, by running `bin/llvm-lit -v path/to/test/ExecutionEngine/Foo/file.s`, for a subdirectory tree with the same command pointing to a directory, or all of them (with `ninja check-llvm`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69434/new/

https://reviews.llvm.org/D69434