[PATCH] D69794: [AMDGPU][SILoadStoreOptimizer] Merge TBUFFER loads/stores

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 00:45:07 PST 2019


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM.

As a general rule, I think we should avoid unrelated whitespace changes, of which this patch has a few, because it can make merging/cherry-picking/rebasing/blaming more confusing. If you're using clang-format, a good way to achieve this is to pipe the output of `git show -U0`, `git diff -U0` or similar into `clang-format-diff -p1`. It's acceptable here though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69794/new/

https://reviews.llvm.org/D69794





More information about the llvm-commits mailing list