[PATCH] D70210: [MirNamer][Canonicalizer]: Perform instruction semantic based renaming

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 00:21:33 PST 2019


aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRNamerPass.cpp:61
     for (auto &MBB : RPOT)
-      Changed |= NVC.renameVRegs(MBB);
+      Changed |= Renamer.renameVRegs(MBB);
 
----------------
plotfi wrote:
> Where is the BB# being set here? All the BB#s will be 0 as far as I can tell. 
Yup - you're right. While trying to refactor I removed a `CurrentBBNo = BBNo++` or something equivalent that I had in my tree. Good catch. Thanks.
I'll have a patch ready for this part soon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70210/new/

https://reviews.llvm.org/D70210





More information about the llvm-commits mailing list