[PATCH] D70464: [COFF] Widen PE32Header fields to fit 64 bit versions

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 00:09:56 PST 2019


mstorsjo added a comment.

In D70464#1752563 <https://reviews.llvm.org/D70464#1752563>, @rnk wrote:

> lgtm
>
> Last time we did this, we just widened the relevant fields for bigobj:
>  rG4d57159c09b226a5608a26c1bc57f7b66cb80a24 <https://reviews.llvm.org/rG4d57159c09b226a5608a26c1bc57f7b66cb80a24>


Ah, good point - as this struct doesn't need to match any on-disk layout we could just do that instead. Will update with a new iteration of the patch (and commit within a couple days if there's no opposition to that form).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70464/new/

https://reviews.llvm.org/D70464





More information about the llvm-commits mailing list