[PATCH] D70373: [NFC] [PowerPC] Add volatile flag to a swap optimization test

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 21:38:16 PST 2019


qiucf added a comment.

In D70373#1750891 <https://reviews.llvm.org/D70373#1750891>, @lkail wrote:

> My concern is `store` and `store volatile` are so different in semantics that it might break original test intention.




In D70373#1750900 <https://reviews.llvm.org/D70373#1750900>, @steven.zhang wrote:

> Agree with Kai. You need some evidence to show that, this won't break the test point.


The two tests are testing functionality of swap removal which runs on machine functions. `volatile` won't affect generated MIR here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70373/new/

https://reviews.llvm.org/D70373





More information about the llvm-commits mailing list