[PATCH] D70468: [ELF] Error if -Ttext-segment is specified

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 21:32:25 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Options.td:62
 
+def Ttext_segment: Separate<["-", "--"], "Ttext-segment">, HelpText<"Unsupported">;
+
----------------
I'd remove HelpText so that it is recognized but doesn't appear in the --help message, unless you actually try to use the option. We have other unsupported options, and showing only this one seems a bit odd to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70468/new/

https://reviews.llvm.org/D70468





More information about the llvm-commits mailing list