[PATCH] D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 20:57:31 PST 2019
ruiu added a comment.
I think this feature is worth more attention. There may be someone who wants to start using this once it's landed, and I'd make sure that we satisfy their needs. Do you mind if I ask you to start a thread on llvm-dev to propose this feature? I think that even a comment like "we'll use this" is valuable. tlike "
================
Comment at: lld/ELF/Writer.cpp:2755
+std::tuple<size_t, size_t> CropHeaderBytes(PhdrEntry *programHeader,
+ PhdrEntry *programHeaderTable,
----------------
Do you think you can move the new code to watermark.{cpp,h} and add file comment to explain (1) what this is and (2) how watermark is computed?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66426/new/
https://reviews.llvm.org/D66426
More information about the llvm-commits
mailing list