[PATCH] D69579: [libFuzzer] Fix unwinding for Fuchsia

Marco Vanotti via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 18:05:15 PST 2019


charco added a comment.

Thanks for the comments!

@phosek can you land this change?



================
Comment at: compiler-rt/lib/fuzzer/FuzzerUtilFuchsia.cpp:81
+// CFAOffset is used to reference the stack pointer before entering the
+// trampoline (Stack Pointer - CFAOffset = prev Stack Pointer). Before jumping
+// to the trampoline we copy all the registers onto the stack. We need to make
----------------
eep wrote:
> Nit: sign error, SP + offset = SP_prev
Thanks for catching this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69579/new/

https://reviews.llvm.org/D69579





More information about the llvm-commits mailing list